Open
Bug 866623
Opened 11 years ago
Updated 2 years ago
Firefox spoils cyrillic text in the Network Monitor response tab
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(Not tracked)
REOPENED
Firefox 23
People
(Reporter: ru-vadik, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 9 obsolete files)
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20130428 Firefox/23.0 Build ID: 20130428031010 Steps to reproduce: 1. Nightly Button -> Web Developer -> Network 2. Go to rbc.ru 3. Open "/" File 4. Click on Response Actual results: <title>РоÑÐизнеÑÐонÑалÑинг - новоÑÑи, акÑии, кÑÑÑÑ Ð²Ð°Ð»ÑÑ, погода, доллаÑ, евÑо</title> Expected results: <title>РосБизнесКонсалтинг - новости, акции, курсы валют, погода, доллар, евро</title>
Updated•11 years ago
|
Component: Developer Tools → Developer Tools: Netmonitor
Updated•11 years ago
|
OS: Windows 7 → All
Priority: -- → P2
Hardware: x86 → All
Updated•11 years ago
|
Assignee: nobody → vporof
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 1•11 years ago
|
||
Attachment #743061 -
Flags: review?(rcampbell)
Comment 2•11 years ago
|
||
Comment on attachment 743061 [details] [diff] [review] v1 Review of attachment 743061 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/netmonitor/test/sjs_content-type-test-server.sjs @@ +13,5 @@ > switch (format) { > + case "txt": { > + response.setStatusLine(request.httpVersion, 200, "OK"); > + response.setHeader("Content-Type", "text/plain", false); > + response.write("Братан, ты даже поднять?"); Братан, ты даже поднять?
Attachment #743061 -
Flags: review?(rcampbell) → review+
Comment 3•11 years ago
|
||
Anton, please let us know of this question's grammatical accuracy. I'm afraid I was only able to resort to primitive methods of translation, as all my Russian connections seem to be busy at the moment.
Flags: needinfo?(anton)
Whiteboard: [land-in-fx-team]
Comment 4•11 years ago
|
||
This is a very literal translation of, I assume, "Bro, do you even lift?" and, unfortunately, it doesn't make any sense. The word поднять means "to pick up" (as in "pick up a box" but not lift in terms of weightlifting). Anyway, the "bro do you even lift" is a very American thing because in post-Soviet countries we have more pressing problems to deal with such as speeding on highways, wrestling bears and assembling/disassembling AK47 for time. But if I were to attempt to translate this question I'd make "Братан, ты вообще качаешься?" or "Братан, ты в зал-то ходишь?" (Bro, do you even go to the gym?) Hope my answer will move the open web forward.
Flags: needinfo?(anton)
Comment 5•11 years ago
|
||
Cosmetic criticism: the patch consistently misspells "cyrillic" with only one l.
Updated•11 years ago
|
Summary: Firefox spoils cyrilic text in the Web Developer Console → Firefox spoils cyrillic text in the Network Monitor response tab
Comment 8•11 years ago
|
||
good to land?
Comment 9•11 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #8) > good to land? Needs rebase or landed after bug 859041 :)
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ba062746f3e7
Whiteboard: [fixed-in-fx-team]
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba062746f3e7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Reporter | ||
Comment 12•11 years ago
|
||
Reporter | ||
Comment 13•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130516 Firefox/24.0 Patch don't work. See reopen.png.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 14•11 years ago
|
||
:( I'll take a look again.
Comment 15•11 years ago
|
||
Fixed convertToUnicode misbehaving when a request has no attached contentCharset and added more thorough testing.
Attachment #742962 -
Attachment is obsolete: true
Attachment #743061 -
Attachment is obsolete: true
Attachment #750501 -
Attachment is obsolete: true
Attachment #751335 -
Flags: review?(rcampbell)
Comment 16•11 years ago
|
||
Went through try and this happens on Windows: IOError: [Errno 2] No such file or directory: u'e:\\builds\\moz2_slave\\try-w32-0000000000000000000000\\build\\browser\\devtools\\netmonitor\\test\\html_\u043a\u0438\u0440\u0438\u043b\u043b\u0438\u0446\u0430-test-page.html' (sigh) Reverted to a more traditional test filename. This will have to do. Sorry about the double r? robcee.
Attachment #751335 -
Attachment is obsolete: true
Attachment #751335 -
Flags: review?(rcampbell)
Attachment #751384 -
Flags: review?(rcampbell)
Comment 17•11 years ago
|
||
Comment on attachment 751384 [details] [diff] [review] v2.1 Review of attachment 751384 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/netmonitor/netmonitor-view.js @@ +716,5 @@ > domain.setAttribute("value", hostPort); > domain.setAttribute("tooltiptext", hostPort); > > + let waterfall = $(".requests-menu-waterfall", template); > + waterfall.style.backgroundImage = this._cachedWaterfallBackground; This is here because I observed that on http://www.rbc.ru/ very rapid succession of requests render empty waterfalls for a split second (which was to be expected, but I had no idea it could be so ugly in some cases; this shouldn't cause any performance issues).
Comment 18•11 years ago
|
||
Green! https://tbpl.mozilla.org/?tree=Try&rev=f706348c697d
Updated•11 years ago
|
Attachment #751384 -
Flags: review?(rcampbell) → review+
Comment 19•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a82fc9b83ea9
Whiteboard: [fixed-in-fx-team]
Comment 20•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a82fc9b83ea9
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Comment 21•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130531 Firefox/24.0 - fix don't work.
Comment 22•11 years ago
|
||
Works for me on OS X, I'll test on Windows shortly. Maybe your nightly isn't up to date?
Reporter | ||
Comment 23•11 years ago
|
||
Comment 24•11 years ago
|
||
Just tested on Linux and Windows and it works as expected. I'm marking this bug as FIXED again because I just can't reproduce the problem. I don't know what to make of your screenshot though.. If you could possibly find a reduced test case and file a new bug, or try a clean profile, that'd be immensely helpful.
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 25•11 years ago
|
||
After create new profile cyrilic text is OK. Thanks.
Reporter | ||
Comment 27•11 years ago
|
||
Firefox 24 beta1
Reporter | ||
Comment 28•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20100101 Firefox/24.0 Bug not fixed. Firefox be installed on clear Windows. See cyrilic_broken.png.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 29•11 years ago
|
||
You just said in comment #25 that after creating a new profile, it works ok. Also, as per comment #24, from my testing, things seem to work as expected. I'm having a very hard time trying to reproduce this bug.
Assignee: vporof → nobody
Priority: P2 → P3
Reporter | ||
Comment 30•11 years ago
|
||
Сurrently not work. After create new profile too.
Updated•11 years ago
|
Attachment #745017 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #751384 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #756950 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #756961 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #756975 -
Attachment is obsolete: true
Comment 31•11 years ago
|
||
Works for me on www.rbc.ru (https://bugzilla.mozilla.org/attachment.cgi?id=788552) But I also tried actions, described in https://bugzilla.mozilla.org/show_bug.cgi?id=892435 and for http://www.google.ru/?q=тест I see q: "B5AB" in Params – Query string ("тест" means "test" in Russian too)
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Blocks: netmonitor-response-sidepanel
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•