866623 - Firefox spoils cyrillic text in the Network Monitor response tab

Status: REOPENED

(DevTools :: Netmonitor, defect, P3)

Description

[ru-vadik]

Attachment: bug_screenshot.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20130428 Firefox/23.0
Build ID: 20130428031010

Steps to reproduce:

1. Nightly Button -> Web Developer -> Network
2. Go to rbc.ru
3. Open "/" File
4. Click on Response


Actual results:

<title>РоÑÐизнеÑÐонÑалÑинг - новоÑÑи, акÑии, кÑÑÑÑ Ð²Ð°Ð»ÑÑ, погода, доллаÑ, евÑо</title>


Expected results:

<title>РосБизнесКонсалтинг - новости, акции, курсы валют, погода, доллар, евро</title>

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 743061 [details] [diff] [review]
v1

Review of attachment 743061 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/test/sjs_content-type-test-server.sjs
@@ +13,5 @@
>      switch (format) {
> +      case "txt": {
> +        response.setStatusLine(request.httpVersion, 200, "OK");
> +        response.setHeader("Content-Type", "text/plain", false);
> +        response.write("Братан, ты даже поднять?");

Братан, ты даже поднять?

Comment 3

[Victor Porof [:vporof][:vp]]

Anton, please let us know of this question's grammatical accuracy. I'm afraid I was only able to resort to primitive methods of translation, as all my Russian connections seem to be busy at the moment.

Comment 4

[Anton Kovalyov (:anton)]

This is a very literal translation of, I assume, "Bro, do you even lift?" and, unfortunately, it doesn't make any sense. The word поднять means "to pick up" (as in "pick up a box" but not lift in terms of weightlifting). Anyway, the "bro do you even lift" is a very American thing because in post-Soviet countries we have more pressing problems to deal with such as speeding on highways, wrestling bears and assembling/disassembling AK47 for time.

But if I were to attempt to translate this question I'd make "Братан, ты вообще качаешься?" or "Братан, ты в зал-то ходишь?" (Bro, do you even go to the gym?)

Hope my answer will move the open web forward.

Comment 5

[Zack Weinberg (:zwol)]

Cosmetic criticism: the patch consistently misspells "cyrillic" with only one l.

Comment 6

[Victor Porof [:vporof][:vp]]

darn.

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Fixed typo, changed response text.

Comment 8

[Rob Campbell [:rc] (:robcee)]

good to land?

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #8)
> good to land?

Needs rebase or landed after bug 859041 :)

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/ba062746f3e7

Comment 11

[Joe Walker [:jwalker]]

https://hg.mozilla.org/mozilla-central/rev/ba062746f3e7

Comment 12

[ru-vadik]

Attachment: Path don't work

Comment 13

[ru-vadik]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130516 Firefox/24.0
Patch don't work. See reopen.png.

Comment 14

[Victor Porof [:vporof][:vp]]

:( I'll take a look again.

Comment 15

[Victor Porof [:vporof][:vp]]

Attachment: v2

Fixed convertToUnicode misbehaving when a request has no attached contentCharset and added more thorough testing.

Comment 16

[Victor Porof [:vporof][:vp]]

Attachment: v2.1

Went through try and this happens on Windows:
IOError: [Errno 2] No such file or directory: u'e:\\builds\\moz2_slave\\try-w32-0000000000000000000000\\build\\browser\\devtools\\netmonitor\\test\\html_\u043a\u0438\u0440\u0438\u043b\u043b\u0438\u0446\u0430-test-page.html' 

(sigh) 

Reverted to a more traditional test filename. This will have to do.
Sorry about the double r? robcee.

Comment 17

[Victor Porof [:vporof][:vp]]

Comment on attachment 751384 [details] [diff] [review]
v2.1

Review of attachment 751384 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-view.js
@@ +716,5 @@
>      domain.setAttribute("value", hostPort);
>      domain.setAttribute("tooltiptext", hostPort);
>  
> +    let waterfall = $(".requests-menu-waterfall", template);
> +    waterfall.style.backgroundImage = this._cachedWaterfallBackground;

This is here because I observed that on http://www.rbc.ru/ very rapid succession of requests render empty waterfalls for a split second (which was to be expected, but I had no idea it could be so ugly in some cases; this shouldn't cause any performance issues).

Comment 18

[Victor Porof [:vporof][:vp]]

Green! https://tbpl.mozilla.org/?tree=Try&rev=f706348c697d

Comment 19

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/a82fc9b83ea9

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a82fc9b83ea9

Comment 21

[ru-vadik]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130531 Firefox/24.0 - fix don't work.

Comment 22

[Victor Porof [:vporof][:vp]]

Attachment: os x

Works for me on OS X, I'll test on Windows shortly. Maybe your nightly isn't up to date?

Comment 23

[ru-vadik]

Attachment: Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130531 Firefox/24.0

Comment 24

[Victor Porof [:vporof][:vp]]

Attachment: windows

Just tested on Linux and Windows and it works as expected. I'm marking this bug as FIXED again because I just can't reproduce the problem.

I don't know what to make of your screenshot though.. If you could possibly find a reduced test case and file a new bug, or try a clean profile, that'd be immensely helpful.

Comment 25

[ru-vadik]

After create new profile cyrilic text is OK. Thanks.

Comment 27

[ru-vadik]

Attachment: cyrilic_broken.png

Firefox 24 beta1

Comment 28

[ru-vadik]

Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20100101 Firefox/24.0

Bug not fixed. Firefox be installed on clear Windows. See cyrilic_broken.png.

Comment 29

[Victor Porof [:vporof][:vp]]

You just said in comment #25 that after creating a new profile, it works ok. Also, as per comment #24, from my testing, things seem to work as expected. I'm having a very hard time trying to reproduce this bug.

Comment 30

[ru-vadik]

Сurrently not work. After create new profile too.

Comment 31

[Infocatcher]

Attachment: fx26_network_cyrillic_query_string.png

Works for me on www.rbc.ru (https://bugzilla.mozilla.org/attachment.cgi?id=788552)
But I also tried actions, described in https://bugzilla.mozilla.org/show_bug.cgi?id=892435 and for
http://www.google.ru/?q=тест
I see
q: "B5AB"
in Params – Query string
("тест" means "test" in Russian too)